Wrong argument order in fStream::revert

This is for people involved in the developement of Snes9x, or SNES emulators in general.
BUG REPORTS BELONG IN TECH SUPPORT/BUG TRACKING!
Post Reply
User avatar
gocha
Snes9x Yellow Belt
Posts: 64
Joined: Sun Dec 30, 2007 12:14 am
Location: Japan, Nagoya

Wrong argument order in fStream::revert

Post by gocha »

I found a simple but a fatal bug. Because of this, loading a movie snapshot never succeed.

Code: Select all

9c483d87a4704965e783521f3990fdb808d1c6e4
 stream.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/stream.cpp b/stream.cpp
index 0d4082c..9bc0fb1 100644
--- a/stream.cpp
+++ b/stream.cpp
@@ -283,7 +283,7 @@ size_t fStream::size (void)
 
 int fStream::revert (size_t from, size_t offset)
 {
-    return (REVERT_FSTREAM(fp, from, offset));
+    return (REVERT_FSTREAM(fp, offset, from));
 }
 
 void fStream::closeStream()
User avatar
OV2
Official Win32 Porter/Dev
Posts: 679
Joined: Thu Aug 30, 2007 10:15 pm

Re: Wrong argument order in fStream::revert

Post by OV2 »

Thanks, committed.

For those changes you already have on github it's enough to post a link to the commit or simply the commit hash, I can take them from there. Might save you some time ;)
User avatar
gocha
Snes9x Yellow Belt
Posts: 64
Joined: Sun Dec 30, 2007 12:14 am
Location: Japan, Nagoya

Re: Wrong argument order in fStream::revert

Post by gocha »

Thank you.
OV2 wrote:For those changes you already have on github it's enough to post a link to the commit or simply the commit hash, I can take them from there. Might save you some time ;)
I see, thanks OV2.
Post Reply