Page 1 of 1

x64 crash fix

Posted: Sat Jan 31, 2015 3:30 pm
by DaMan
Opening input config/customize hotkey would crash 64bit builds made with VS10 and newer (assuming it doesn't affect VS08 since official builds don't crash).

Re: x64 crash fix

Posted: Sun Feb 01, 2015 12:48 am
by OV2
Thanks, merged to github.

Re: x64 crash fix

Posted: Sun Feb 01, 2015 12:45 pm
by DaMan
You're welcome, but you missed a few things.
GetClassLong -> GetClassLongPtr in wsnes.cpp.
GetWindowLong -> GetWindowLongPtr in InputCustom.cpp and on line 841

Code: Select all

SetWindowLongPtr(hwnd, 0, (LONG)icp);
to

Code: Select all

SetWindowLongPtr(hwnd, 0, (LONG_PTR)icp);

Re: x64 crash fix

Posted: Sun Feb 01, 2015 2:13 pm
by OV2
Thanks again - that's what happens if you only look at the diff file instead of applying it ;)

However I don't see any GetClassLong calls in the entire project.

Re: x64 crash fix

Posted: Sun Feb 01, 2015 4:17 pm
by DaMan
My bad it was also a GetClassLong in inputcustom. Was watching TV when I was writing that out and multitasking isn't my strong point.