It is currently Sun Dec 17, 2017 9:53 am

All times are UTC




Post new topic Reply to topic  [ 5 posts ] 
Author Message
 Post subject: x64 crash fix
PostPosted: Sat Jan 31, 2015 3:30 pm 
Offline
Snes9x White Belt

Joined: Thu Jan 22, 2015 2:35 pm
Posts: 27
Opening input config/customize hotkey would crash 64bit builds made with VS10 and newer (assuming it doesn't affect VS08 since official builds don't crash).


Attachments:
Fix-x64.zip [1.36 KiB]
Downloaded 315 times
Top
 Profile  
Reply with quote  
 Post subject: Re: x64 crash fix
PostPosted: Sun Feb 01, 2015 12:48 am 
Offline
Official Win32 Porter/Dev
User avatar

Joined: Thu Aug 30, 2007 10:15 pm
Posts: 594
Thanks, merged to github.


Top
 Profile  
Reply with quote  
 Post subject: Re: x64 crash fix
PostPosted: Sun Feb 01, 2015 12:45 pm 
Offline
Snes9x White Belt

Joined: Thu Jan 22, 2015 2:35 pm
Posts: 27
You're welcome, but you missed a few things.
GetClassLong -> GetClassLongPtr in wsnes.cpp.
GetWindowLong -> GetWindowLongPtr in InputCustom.cpp and on line 841
Code:
SetWindowLongPtr(hwnd, 0, (LONG)icp);

to
Code:
SetWindowLongPtr(hwnd, 0, (LONG_PTR)icp);


Top
 Profile  
Reply with quote  
 Post subject: Re: x64 crash fix
PostPosted: Sun Feb 01, 2015 2:13 pm 
Offline
Official Win32 Porter/Dev
User avatar

Joined: Thu Aug 30, 2007 10:15 pm
Posts: 594
Thanks again - that's what happens if you only look at the diff file instead of applying it ;)

However I don't see any GetClassLong calls in the entire project.


Top
 Profile  
Reply with quote  
 Post subject: Re: x64 crash fix
PostPosted: Sun Feb 01, 2015 4:17 pm 
Offline
Snes9x White Belt

Joined: Thu Jan 22, 2015 2:35 pm
Posts: 27
My bad it was also a GetClassLong in inputcustom. Was watching TV when I was writing that out and multitasking isn't my strong point.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group