It is currently Sun May 19, 2013 7:38 pm

View unanswered posts | View active topics


Board index » Snes9x » Snes9x Tech Support and Bug Tracking

All times are UTC




Post new topic Reply to topic  Page 1 of 1
  [ 7 posts ] 
  Print view Previous topic | Next topic 
Author Message
odditude
PostPosted: Sat Nov 12, 2011 2:33 pm 
Offline
Snes9x Yellow Belt

Joined: Tue May 03, 2011 2:35 pm
Posts: 190
dialog should probably be widened to handle longer lines to avoid breaking the indent.

text formatting is off (or at least inconsistent) on nitsuja's copyright line.

last line dies mid-sentence ("Snes9x is a Super Nintendo Entertainment System") - don't know how much text there's supposed to be after that.
Top
 Profile  
 
bl0ckeduser
 Post subject:
PostPosted: Tue Nov 15, 2011 12:13 am 
Offline
Snes9x White Belt

Joined: Tue Nov 15, 2011 12:12 am
Posts: 27
Hello, I'm a somewhat noob programmer, but I think I can fix this one. I'll be sending in a patch.
Top
 Profile  
 
bl0ckeduser
 Post subject:
PostPosted: Tue Nov 15, 2011 1:17 am 
Offline
Snes9x White Belt

Joined: Tue Nov 15, 2011 12:12 am
Posts: 27
Okay, I've sent a pull request on GitHub. This is what the fixed dialog box looks like:

Image

Thanks for pointing this out.
Top
 Profile  
 
adventure_of_link
 Post subject:
PostPosted: Tue Nov 15, 2011 3:56 am 
Offline
Hero of Hyrule | Official Port Recruiter

Joined: Mon May 24, 2004 5:06 pm
Posts: 2490
Location: 255.255.255.255
nice work! :)

_________________
Image

Unofficial Test Monkey For:
* Snes9X GX (Wii)
* Snes9X EX (Android)
* Snes9X 64-bits

ZSNES|Ben Heck|NSRT|Bob Smiley
Top
 Profile  
 
Camo_Yoshi
 Post subject:
PostPosted: Tue Nov 15, 2011 3:49 pm 
Offline
Snes9x Purple belt
User avatar

Joined: Thu Nov 08, 2007 7:59 pm
Posts: 909
Location: /dev/null
This'll be merged into the main code and will be present in Snes 1.54. :)

Thanks for your fix!

_________________
Snes9x FAQs | Forum Rules
What operating system are you using? 32 or 64bit? Version of Snes9x? Is the text at the bottom of the window white when you load the game?
These suggestions are usually the solution to your issue!
Top
 Profile  
 
OV2
 Post subject:
PostPosted: Tue Nov 15, 2011 11:59 pm 
Offline
Official Win32 Porter/Dev
User avatar

Joined: Thu Aug 30, 2007 10:15 pm
Posts: 450
Thanks, commited. I'll probably also make it a bit larger so that the whole lines fit into the window ;)
Top
 Profile  
 
bl0ckeduser
 Post subject:
PostPosted: Wed Nov 16, 2011 12:06 am 
Offline
Snes9x White Belt

Joined: Tue Nov 15, 2011 12:12 am
Posts: 27
Nice. Thanks for the merge.
Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  Page 1 of 1
  [ 7 posts ] 

Board index » Snes9x » Snes9x Tech Support and Bug Tracking

All times are UTC


Who is online

Users browsing this forum: Google Adsense [Bot] and 4 guests

You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group